Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: update doc for tidb_opt_prefer_range_scan #6859

Merged
merged 1 commit into from
Sep 6, 2021
Merged

sysvar: update doc for tidb_opt_prefer_range_scan #6859

merged 1 commit into from
Sep 6, 2021

Conversation

xuyifangreeneyes
Copy link
Contributor

What is changed, added or deleted? (Required)

Update doc for tidb_opt_prefer_range_scan.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2021
@xuyifangreeneyes
Copy link
Contributor Author

/cc @winoros

TomShawn
TomShawn reviewed Aug 13, 2021
View reviewed changes
system-variables.md
@@ -1109,10 +1109,10 @@ mysql> desc select count(distinct a) from test.t;

### `tidb_opt_prefer_range_scan` <span class="version-mark">从 v5.0 版本开始引入</span>

- 作用域：SESSION
- 作用域：SESSION | GLOBAL
- 默认值：`OFF`
Copy link
Contributor

@TomShawn TomShawn Aug 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/0，ON/OFF 是否需要统一一下呢？另外，这个属于 5.2 有的内容吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不属于 5.2 的内容，要不统一成 ON/OFF ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Aug 13, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 13, 2021
@TomShawn TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Aug 13, 2021
@ti-chi-bot
Copy link
Member

@winoros: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@TomShawn
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021
@TomShawn TomShawn removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@TomShawn
Copy link
Contributor

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dddf1c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@TomShawn TomShawn closed this Sep 6, 2021
@TomShawn TomShawn reopened this Sep 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 6, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit b5e7456 into pingcap:master Sep 6, 2021
@en-jin19 en-jin19 mentioned this pull request Sep 6, 2021
Merged
12 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 6, 2021
@xuyifangreeneyes xuyifangreeneyes deleted the prefer-range-scan branch October 30, 2021 05:05
@nongfushanquan nongfushanquan mentioned this pull request Aug 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@en-jin19 en-jin19

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xuyifangreeneyes @ti-chi-bot @TomShawn @winoros @en-jin19